JS: Fix some Ql4Ql violations. #20329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
javascript/ql4ql
branch
from
5ff650b to
8b10ad4
Compare
michaelnebel
added
the
no-change-note-required
There was a problem hiding this comment.
Pull Request Overview
This PR fixes various Ql4Ql violations across JavaScript CodeQL files, focusing on code quality improvements including naming conventions, spelling corrections, and code simplification.
Key changes include:
- Renaming dataflow configuration modules to follow naming conventions
- Correcting spelling from British "modelling" to American "modeling" and fixing other typos
- Refactoring code to eliminate unused private fields
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| javascript/ql/test/library-tests/FlowSummary/test.ql | Renamed dataflow configuration modules to follow naming conventions |
| javascript/ql/src/Declarations/UnreachableMethodOverloads.ql | Removed unused private field by inlining variable declaration |
| javascript/ql/lib/semmle/javascript/security/TaintedUrlSuffixCustomizations.qll | Fixed spelling error: "preverse" to "preserve" |
| javascript/ql/lib/semmle/javascript/internal/flow_summaries/Strings.qll | Fixed spelling: "modelling" to "modeling" and "behaviour" to "behavior" |
| javascript/ql/lib/semmle/javascript/internal/flow_summaries/Sets.qll | Fixed spelling: "modelling" to "modeling" |
| javascript/ql/lib/semmle/javascript/internal/flow_summaries/Promises.qll | Fixed spelling: "modelling" to "modeling" |
| javascript/ql/lib/semmle/javascript/internal/flow_summaries/Maps.qll | Fixed spelling: "modelling" to "modeling" |
| javascript/ql/lib/semmle/javascript/internal/flow_summaries/Iterators.qll | Fixed spelling: "modelling" to "modeling" |
| javascript/ql/lib/semmle/javascript/internal/flow_summaries/Generators.qll | Fixed spelling: "modelling" to "modeling" |
| javascript/ql/lib/semmle/javascript/internal/flow_summaries/AsyncAwait.qll | Fixed spelling: "modelling" to "modeling" |
| javascript/ql/lib/semmle/javascript/internal/flow_summaries/Arrays.qll | Fixed spelling: "modelled" to "modeled" and "behaviour" to "behavior" |
| javascript/ql/lib/semmle/javascript/frameworks/data/internal/ApiGraphModelsSpecific.qll | Fixed spelling: "refering" to "referring" |
| javascript/ql/lib/semmle/javascript/frameworks/Babel.qll | Removed unused private field by moving variable into exists clause |
| javascript/ql/lib/semmle/javascript/dataflow/internal/VariableCapture.qll | Fixed spelling: "langauge" to "language" |
| javascript/ql/lib/semmle/javascript/dataflow/internal/DataFlowPrivate.qll | Fixed spelling: "modelled" to "modeled" |
| javascript/ql/lib/semmle/javascript/dataflow/internal/BarrierGuards.qll | Removed unused private field by moving variable into exists clause |
| javascript/ql/lib/semmle/javascript/dataflow/FlowSummary.qll | Fixed spelling: "behaviour" to "behavior" and "modelled" to "modeled" |
owen-mc
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some Ql4Ql violations based on the following checks
ql/field-only-used-in-charpredql/could-be-castql/counting-to-zeroql/dataflow-module-naming-conventionql/if-with-noneql/missing-parameter-qldocql/misspellingDCA looks good.